LBL-EESA / alquimia-dev

Alquimia is an interface that exposes the capabilities of mature geochemistry codes such as [CrunchFlow](http://www.github.com/cisteefel/crunchtope) and [PFLOTRAN](https://bitbucket.org/pflotran/pflotran-dev).
Other
18 stars 30 forks source link

case sensitive functionality #69

Open smolins opened 4 years ago

smolins commented 4 years ago

There is no information about whether engines cannot take in case sensitive strings, in particular condition labels. (reported by @lipnikov)

Neither CrunchFlow nor PFLOTRAN are case-sensitive for condition labels. The problem with CrunchFlow was that I did not implement the appropriate function in the Crunchflow alquimia interface. Technically, a bug. Fixed in pull request  (closes #68)

We need to add a new functionality variable that tells the user whether one can pass driver-derived strings as case sensitive or not. Engine-derived strings may need to be assumed case-sensitive.

We need to decide how general this variable can be (task: go over every string that goes into Alquimia). At the very least, the variable will indicate whether condition%name is case-sensitive or not, e.g. "bool functionality%label_case_sensitive".