LBL-EESA / fastkde

Other
50 stars 10 forks source link

Wheels #2

Closed davidt0x closed 3 years ago

davidt0x commented 3 years ago

Hi,

First, thanks for the great package. I wanted to use it for a project I am involved in but there didn't seem to be any wheels built for it. I forked your repo and put together a GitHub action for building wheels for Python 3.5-3.9 on Mac, Windows, and Linux. Any chance you would like to upstream this workflow into your repo? This pull request should set it all up. The only thing you would need to do is create and PyPi API token for your account and add it as a repo secret called PYPI_PASSWORD. The action would be triggered anytime you tag a release. Note, it will only be triggered on new releases so you would need to bump the version when creating the release.

I tried to make the minimal changes to your repo to get this working. Please see the commits but here is an overview:

Anyway, thanks again for the package!

Dave

taobrienlbl commented 3 years ago

Dear @davidt0x ,

What an unexpected and wonderful PR!!! This has been on my TODO list for several years now, but it's never risen high enough for me to get over the barrier of learning how to build multidistribution wheels.

I'll definitely be merging this in. I'll review the commits momentarily, but from my first glance, it looks like everything is in great shape.

I can't tell you how delighted and grateful I am that you did this: thank you!!

-Travis-

davidt0x commented 3 years ago

No problem Travis. In the past it was usually a pain but with tools like cibuildwheel it has gotten much better. Anyway, thanks for upstreaming and thanks for the cool package.

Dave