search

LBL-EESA / fastkde

Other
50 stars 10 forks source link

Fix wheel release #21

Closed davidt0x closed 1 year ago

davidt0x commented 1 year ago

@taobrienlbl, this PR fixes a small error introduced by PR #20 that is leading to the actions workflow not being triggered on release. Wheels were not uploaded when you manually triggered the action since they are only uploaded on the condition that the action is triggered by a published release. The error I introduced is a few lines in the on: section of the workflow yml. The release and push triggers are indented one too many times and thus ignored. I believe this fixes the issue. I tested on my fork with a release and it seems to trigger properly now. Make sure to use a new release when triggering though, v1.0.23 I guess. Sorry for the trouble.

taobrienlbl commented 1 year ago

ah that makes sense. I wondered if I had made a mistake when I tagged the new release. Thanks!