search

LBNL-ETA / AERCalc

Other
1 stars 1 forks source link

AERCalc - ESCalc not using precalculated values #10

Open RDmitchell opened 4 years ago

RDmitchell commented 4 years ago

Email from @StephenCzarnecki

Files he is referencing are in the AERCalc issues folder G:\Shared drives\AERCalc\Github Issues\Github Issue 7 Link to folder https://drive.google.com/drive/folders/1r2rGEd8zSVwmL2rRNV8-kb9i4n5KEv3j?usp=sharing

Here is a link to a folder that runs the ESCalc code without using any precalculated results.

https://drive.google.com/file/d/12g6Ctof5e5_6BX9hhfuzdgLNDhZ2kwmi

To use it replace the contents of existing folder located at

C:\Users\dev\AppData\LBNL\aercalc\EP_Weighting_Scripts_ESCalc

You may want to just rename the existing folder to have as a backup.

This should work with any existing AERCalc version.

It took me a little longer because I wanted to check the results first. I initially compared the results I got to those from the latest released version, 1.2.10, and found that the results changed more than I expected. I didn't want to include any other changes that may have happened due to updates in WINDOW or anything else so I then ran the 1.2.10 installed version with the updated ESCalc.

I've attached AERCalc export files of both 1.2.10 runs and they have different results but the difference is down in the 4th or 5th decimal place which is more in line with what is expected. The original precalculated values were given to the 4th or 5th decimal place. And now they are being calculated at full precision. So it seems to make sense to me that the results would also change at around the same place.

The folder also includes weighting coefficients for the fully shaded and fully open cases. To use one of those instead of the default schedule change the filename to just WeightingCoefficients.txt. You'll probably want to rename the existing WeightingCoefficients.txt to something else to be able to restore later.

I am wondering if it might be a good idea to generate a new set of results with the version I made a little while ago that has window quilts and roller shutters. Because that I think has an updated version of WINDOW and thought it might be a good idea to see if any results changed. But if we are not going to use that and skip directly to the version of WINDOW that has awnings then maybe just getting results for that is good enough?

Let me know if you have any questions. In the meantime I will try and get a build with awnings working.

RDmitchell commented 3 years ago

@StephenCzarnecki -- can we close this?