LBNL-ETA / AERCalc

Other
1 stars 1 forks source link

Open hourly data not being used in calculations for any shading products #6

Closed RDmitchell closed 4 years ago

RDmitchell commented 4 years ago

@StephenCzarnecki to investigate the issue of whether the program is using the shade open case for the hourly weighting calculations. It seems that it isn't.

RDmitchell commented 4 years ago

Here is the plan to deal with this:

Postdoc (Maryna or Yuan)

If AERCalc results are the same as the new calculation method results, then we can assume that AERCalc is doing the correct calculation,

Charlie

StephenCzarnecki commented 4 years ago

This has been resolved and I think it should be closed.

Resolution was that the open hourly data was being used in the form of a magic number. But that magic number was based on the original weighting schedule. So when the awnings used a different weighting schedule that magic number was no longer correct. The implemented solution was to refactor ESCalc to take the weighting coefficient schedule and calculate the weighted open values based on that schedule.

RDmitchell commented 4 years ago

Thanks Stephen. Am closing