Simplify user_select_file() method using only tkinter.

LBNL-ETA / Adapter

The Adapter software is developed at the Energy Efficiency Standards Department and it provides a convenient data table loader from various formats such as xlsx, csv, db (sqlite database), and sqlalchemy. Its main feature is the ability to convert data tables identified in one main and optionally one or more additional input files into database tables and Pandas DataFrames for downstream usage in any compatible software.

1 stars 1 forks source link

Simplify user_select_file() method using only tkinter. #43

Closed rhosbach closed 7 months ago

rhosbach commented 8 months ago

Used tkinter only to simplify the user_select_file() method in tools.py. Please test on multiple OSs, if possible.

lyralan commented 8 months ago

Thanks Rob! Happy to see this being implemented in a more consistent and concise way.

It works for me on MacOS. I circled around folks who have used linux servers (rather than desktop) to run programs, and they just manually type the path to be read in the run script, because GUI is not compatible with the server unless something like VNC viewer is set up, which needs a bunch of other packages installed by the admin. Therefore unfortunately I won't be able to test user_select_file on linux (server). It'd be good if someone can test it on a linux desktop (if not, I wouldn't worry too much about it because I'd imagine anyone using linux could just adjust the run script).

Otherwise it looks pretty good! The tests passed on my end. I think it's good to go as is. Let me know if there's anything else that I might have missed!

0xd5dc commented 8 months ago

I tested it with LCC and had no issue using this branch on Win 10.

lyralan commented 7 months ago

Hi all - it's been quite a while and no one seems to have requested changes. I'm going to approve this PR by Friday as I think this is good to go as is after testing it on my computer, it's backwards compatible, and I don't think this PR should linger forever.

rhosbach commented 7 months ago

Thanks, @lyralan. Completely agreed. @milicag did you have any thoughts before we approve/merge?

milicag commented 7 months ago

All good here!

On Fri, Mar 15, 2024, 7:45 AM rhosbach @.***> wrote:

Thanks, @lyralan https://github.com/lyralan. Completely agreed. @milicag https://github.com/milicag did you have any thoughts before we approve/merge?

— Reply to this email directly, view it on GitHub https://github.com/LBNL-ETA/Adapter/pull/43#issuecomment-1999822299, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABITRP7N7YJFJ3OJLCODMKDYYMCSFAVCNFSM6AAAAABDXQCMXWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOJZHAZDEMRZHE . You are receiving this because you were mentioned.Message ID: @.***>