search

LBNL-ETA / Windows-CalcEngine

Thermal and optical routines for modeling properties of window and shading systems
Other
4 stars 2 forks source link

Rename all entries of gasses to gases #4

Closed CJKohler closed 8 years ago

CJKohler commented 8 years ago

Both the name of the file, and any references, documentation etc

dccurcija commented 8 years ago

Gases vs. gasses

In modern English, the plural of gas is usually gases, and gasses is the simple-present verb http://grammarist.com/grammar/verbs/. For instance, we might say that the more Bill gasses up his car, the more greenhouse gases his car emits. This isn’t a rule, though, and the plural gasses survives, appearing a small percentage of the time.

The verb is so rarely useful (and its senses outside the phrasal verb http://grammarist.com/grammar/phrasal-verbs/ gas up are no fun) that the rare instances of gasses we find on the web are mostly variants of gases. There is one of these for approximately every ten gases.

On Fri, Mar 25, 2016 at 12:44 PM, CJKohler notifications@github.com wrote:

Both the name of the file, and any references, documentation etc

— You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub https://github.com/LBNL-ETA/Windows-CalcEngine/issues/4

--------------------------------------------------------------------------

_D. Charlie Curcija_, Ph.D. * Tel: (510) 495-2602*

Lawrence Berkeley National Laboratory Fax: (510) 486-4089

Windows & Envelope Materials Group Cell:(510) 604-8668

1 Cyclotron Rd., MS 90-3111 Email: dccurcija@lbl.gov dccurcija@lbl.gov

Berkeley, CA 94720 Web: http://windows.lbl.gov/ http://btech.lbl.gov/

--------------------------------------------------------------------------

vidanovic commented 8 years ago

@CJKohler @dccurcija If we are going to change gasses to gases then let me know because now is great time to do that. On side note, related to GitHub. You can refer to a person on github by putting at sign in front of person name. We should probably use that since github have option Unwatch->Not watching. That is good option if person does not want to follow every conversation on github unless someone is putting that person's name in conversation. So if I write this message and I do put @dccurcija then Charlie will get notification that he needs to respond on github, otherwise, he will not get any notification (of course, if his account have appropriate settings).

CJKohler commented 8 years ago

Yes, please change gasses to gases

RDmitchell commented 8 years ago

@vidanovic -- did you mean to say "now" instead of "not" in your comment above. The way it is written it seems like you DON'T want to do it now. Might want to change that?

vidanovic commented 8 years ago

@RDmitchell Yes. It was a typo. Now is a great time :)

vidanovic commented 8 years ago

@CJKohler Yes, all tests are passing. We should actually take a look at options for online testing. That would create online report for everyone to see.

RDmitchell commented 8 years ago

In the SEED world, the PR shows whether or not they have passed and the PR is not merged until the tests have passed. This is using Travis CI which I don't think is appropriate for our world but Alex Swindler passed along info for other test platforms that we could use, which I sent to Simon.

Here is an example of the PR list of unmerged PRs, showing that most have passed the CI tests except for # 880 image

Opening up the PR that failed, this is what you see image

Opening up the PR that passed, here is what you see. Also, we are using a PR template, which I think would be a good protocol to follow, ie, What does this PR do, what Issues does it resolve, etc.

image