LBNL-ETA / pyWinCalc

Other
27 stars 10 forks source link

Add BSDF XML files to shading #6

Open RDmitchell opened 4 years ago

Fan-Feng commented 2 years ago

I just wonder if you are still planning to add this feature into pyWinCalc, and it will be great if this module could generate BSDF file for the glazing system..

StephenCzarnecki commented 2 years ago

@Fan-Feng

Sorry for the delayed response. We have been working on adding quite a lot of features to pywincalc and just merged them into the default branch (which has been renamed to main).

However to get all of the new functionality a lot of the v1 interface had to unfortunately be broken. The good news is that I have tried to substantially update the documentation and examples to cover a much wider set of use cases including being able to use BSDF XML shades in glazing systems as well as creating BSDF results. For more on the different types of optical results now available see https://github.com/LBNL-ETA/pyWinCalc/blob/main/readme.md#Optical-Results

The documentation also contains a section on how to update existing code from the v1 interface to v2. See https://github.com/LBNL-ETA/pyWinCalc/blob/main/readme.md#Migrating-from-version-1 Hopefully it is reasonably clear. If not let me know and I can work on improving it.

Note that BSDF results are only available for systems that are calculated using a BSDF hemisphere. Any system can be calculated using a BSDF hemisphere. For an example of how to create a system that uses a BSDF XML file as a shading layer see https://github.com/LBNL-ETA/pyWinCalc/blob/main/examples/interior_bsdf.py. For an example that uses a BSDF shade that can be downloaded from the IGSDB see https://github.com/LBNL-ETA/pyWinCalc/blob/main/examples/igsdb_interior_bsdf.py

Note that to download product data from the IGSDB you will need to register and get an API token.

And since this is a pretty major change please let us know if you have problems with anything.

Thanks for your interest.