Open sariths opened 1 year ago
@taoning A simple example of rpict is here: https://gist.github.com/sariths/4c93a1a87457edba112212a3e1b23c6a I have added some actionable notes here: https://gist.github.com/sariths/4c93a1a87457edba112212a3e1b23c6a#file-pyradiance_rpict-py-L49-L50
Let me know what you think.
Looks good. Instead of write_to_file
, maybe just write
? I think we have file_path
as the first argument, followed by data
?
If the sky source
is used for an octree
, we can just feed the bytes to stdin
in oconv rather than write to a file first.
In terms of sampling parameters, we can do
params = SamplingParamters()
params.update_from_dict({"-ab":1})
params.ad = 256
params.lw = 1 / params.ad
rpict(..., params=params.args())
Is this similar to what you have in mind?
Okay to all the suggestions. Any thoughts about ra_tiff, ra_bmp etc? I had a comment towards the end of the gist.
On Fri, Aug 4, 2023, 6:43 PM taoning @.***> wrote:
Looks good. Instead of write_to_file, maybe just write? I think we have file_path as the first argument, followed by data?
If the sky source is used for an octree, we can just feed the bytes to stdin in oconv rather than write to a file first.
In terms of sampling parameters, we can do
params = SamplingParamters() params.update_from_dict({"-ab":1})params.ad = 256 params.lw = 1 / params.ad rpict(..., params=params.args())
Is this similar to what you have in mind?
— Reply to this email directly, view it on GitHub https://github.com/LBNL-ETA/pyradiance/issues/24#issuecomment-1666341296, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACPBX6CAEZI6EMGTLBB5PD3XTWQK5ANCNFSM6AAAAAA3ESG46E . You are receiving this because you authored the thread.Message ID: @.***>
Sure, we can add those tools.
Add examples for rtrace, rpict and rfluxmtx.
@taoning I added a discussion regarding the choice of input files here: https://github.com/LBNL-ETA/pyradiance/discussions/23