search

LBNL-UCB-STI / beam

The Framework for Modeling Behavior, Energy, Autonomy, and Mobility in Transportation Systems
https://transportation.lbl.gov/beam
Other
143 stars 57 forks source link

WGS/UTM conversion #3189

Open zneedell opened 3 years ago

zneedell commented 3 years ago

This attempted WGS/UTM conversion tends to throw a lot of errors:

https://github.com/LBNL-UCB-STI/beam/blob/8a428b9e72f6c68e2f4832f4a305ff32e0248437/src/main/scala/beam/utils/scenario/UrbanSimScenarioLoader.scala#L47-L60

I think it's because activity locations already are converted from WGS->UTM when plans are loaded in. There are some issues with WGS/UTM conversion in the Seoul implementation so I'm wondering if this attempted conversion is causing issues.

edwazhao commented 1 year ago

Hi @zneedell , firstly, do you mean the errors are as below warning messages?

01:18:05.075 [main] WARN beam.sim.common.GeoUtilsImpl - [1] Coordinate does not appear to be in WGS. No conversion will happen: [x=604991.4348954696][y=4130362.4638981917] 01:18:05.081 [main] WARN beam.sim.common.GeoUtilsImpl - [2] Coordinate does not appear to be in WGS. No conversion will happen: [x=604991.4348954696][y=4130362.4638981917] 01:18:05.083 [main] WARN beam.sim.common.GeoUtilsImpl - [4] Coordinate does not appear to be in WGS. No conversion will happen: [x=596869.2460295467][y=4128431.4206831288]

edwazhao commented 1 year ago

If the above answer is yes, I did some research of the beam config exchange.scenario.convertWgs2Utm=true and simulations input files analysis. One is that convertWgs2Utm=true and the log with Coordinate does not appear to be in WGS. No conversion will happen: https://beam-outputs.s3.amazonaws.com/output/sfbay/gemini-base-2035-activitysim__2022-08-09_21-07-08_knp/beamLog.out, it use the input files as https://github.com/LBNL-UCB-STI/beam-data-sfbay/raw/develop/activitysim/2018 For the axis information defined in the csv files, for other simulations it has the similar chart. image

One is that convertWgs2Utm=true and the log without Coordinate does not appear to be in WGS. No conversion will happen: https://beam-outputs.s3.amazonaws.com/output/sfbay/sfbay-smart-base__2022-09-06_17-36-15_wfx use the input files https://github.com/LBNL-UCB-STI/beam-data-sfbay/raw/develop/urbansim/2010/baseline image It only have plans with axis information.

Based on the information above, do you think is it possible we are not set the config exchange.scenario.convertWgs2Utm=true to the correct value? Since they look like in the same CRS, no need to do conversion.