Closed haitamlaarabi closed 6 months ago
src/main/scala/beam/utils/geospatial/GeoReader.scala
line 66 at r1 (raw file):
def main(args: Array[String]): Unit = { readFeatures("/Users/haitamlaarabi/Workspace/Data/Scenarios/sfbay/input/sfbay_cbgs.geojson")
Probably want to generalize this or remove it
production/sfbay
line 1 at r1 (raw file):
Subproject commit baa870bc1acf646efbfbdef74243166af45f3e63
Is there any way to get these changes out of the PR?
src/main/scala/beam/agentsim/agents/PersonAgent.scala
line 1554 at r1 (raw file):
def getOriginAndDestination(currentAct: Activity, maybeNextAct: Option[Activity]): (String, String) = { val tazMap = beamScenario.tazTreeMap
I'm probably misunderstanding this, but isn't this pointing to the actual TAZ geometries rather than the smaller CBG geometries? Wouldn't we want to do the initial mapping to the smaller geometries and then aggregate them up to TAZs when outputting the skims?
src/main/scala/beam/router/skim/ActivitySimSkimmer.scala
line 254 at r1 (raw file):
} val filePathWithMapped = if (excerptOfMappedData.nonEmpty) filePath.lastIndexOf(".") match {
Any chance we could keep it so that the mapped (e.g. TAZ) skims have the same file name for backwards compatibility, and change the name of the bg skims? Although I get that it's tricky because when we turn the mapping off the assumption is that the original (pre-mapped) skims are now TAZ rather than BG
Test!
test now!
test now!
test!
test!
test now!
test!
Test now!
test!
test!
test!
test now!
The reason is that in PILATES some models may be operating on different spatial resolutions. For example ActivitySim in SFBay is at TAZ level but FRISM is a CBG level. In here we are mapping TAZ to CBG and then producing two skims: one for ActivitySkim and another for FRISM.
This change is