search

LBPUnion / ProjectLighthouse

Project Lighthouse is a clean-room, open-source custom server for LittleBigPlanet.
GNU Affero General Public License v3.0
211 stars 53 forks source link

Purge Comments Not Working Perfectly #1037

Open m88youngling opened 5 months ago

m88youngling commented 5 months ago

Describe the bug Using the recent purge comments feature from be11e138f032ec306f9c732b4a3a3cee47740edc fails to delete all comments from a user. Most comments will be deleted but some will remain.

To Reproduce Steps to reproduce the behavior:

  1. Find a user spamming your server
  2. Click the button to delete all their comments
  3. (Optional) the user is banned when I observe the behavior.

Expected behavior All comments belonging to the user should be removed, not most of them.

Screenshots The only examples I have are not appropriate for this issue.

skittlez1250 commented 5 months ago

i'd suggest just to remove all comments made from the same IP

m88youngling commented 5 months ago

That would require storing IP addresses in the database again, which we haven't decided is a good idea or not.

jackcaver commented 5 months ago

that's kinda a weird thought, but what i think is happening here is that it actually deletes all the comments that existed at the moment the action was called and since the user is constantly spamming new comments those new ones are not getting deleted, so technically it works as intended it's just the way it works is not effective against spamming

jackcaver commented 5 months ago

i'd suggest just to remove all comments made from the same IP

this is also quite useless i think, since the spammers could have a lot of different IPs and multiple good people could have the same IP as a bad guy, so this could delete all of the comments of innocent people

m88youngling commented 5 months ago

that's kinda a weird thought, but what i think is happening here is that it actually deletes all the comments that existed at the moment the action was called and since the user is constantly spamming new comments those new ones are not getting deleted, so technically it works as intended it's just the way it works is not effective against spamming

I think you are probably right. In that case, best to just click the button multiple times. It might be best to close this issue if that's the case

jackcaver commented 5 months ago

that's kinda a weird thought, but what i think is happening here is that it actually deletes all the comments that existed at the moment the action was called and since the user is constantly spamming new comments those new ones are not getting deleted, so technically it works as intended it's just the way it works is not effective against spamming

I think you are probably right. In that case, best to just click the button multiple times. It might be best to close this issue if that's the case

I think that a better solution to that is disabling user's ability to add comments and then remove all