search

LBPUnion / ProjectLighthouse

Project Lighthouse is a clean-room, open-source custom server for LittleBigPlanet.
GNU Affero General Public License v3.0
211 stars 53 forks source link

General concerns with code quality #968

Open sudokoko opened 10 months ago

sudokoko commented 10 months ago

There are some concerns regarding uniformity of code quality throughout the project. This issue will serve as a discussion point for possible solutions and as a tracking point for related PRs.

m88youngling commented 10 months ago

to quote slendy

"it's time for lighthouse 2"

anyway, what specific concerns do we have with the code quality?

sudokoko commented 10 months ago

Generally, the code quality throughout the project is not uniform and uses a variety of styles. A good first step to resolve this could be to set up a CI linter for pull requests. We could decide on an optimal linter configuration through discussion, as well as maybe fine-tuning our DotSettings file, and have a passing linter be a requirement for PR merge.

m88youngling commented 10 months ago

I'm assuming what that will effectively do is require certain styles and formats of the code and check for syntax automatically to make sure it's compliant?

sudokoko commented 10 months ago

I'm assuming what that will effectively do is require certain styles and formats of the code and check for syntax automatically to make sure it's compliant?

Yes, that is what a linter does