LBRYFoundation / Watch-on-LBRY

Plugin for web browser that automatic check if YouTube video is on LBRY
GNU General Public License v3.0
78 stars 19 forks source link

sub converter doesnt work #104

Closed ghost closed 2 years ago

ghost commented 2 years ago

Describe the bug the converter is stuck at 100% and it doesnt show urls to the odysee channels
To Reproduce Steps to reproduce the behavior:

  1. Go to 'subscription converter'
  2. Click on 'Start Conversion!'

Expected behavior list of links which directs to odysee channels

Screenshots 2022-02-13_17-55

Desktop (please complete the following information):

kodxana commented 2 years ago

What API provider? Cause mine is currently off.

ghost commented 2 years ago

@kodxana what? idk what is that. i am using the add on by Madiator2011

kodxana commented 2 years ago

I was moving DNS stuff thats why API wasn't working but now it should work fine. BTW I'm Madiator :)

ghost commented 2 years ago

still stuck at 100%, i think youtube changed something on the exported file

kodxana commented 2 years ago

Can you check network tab and see if you get any errors?

ghost commented 2 years ago

@kodxana when using madiator it says: Cross-Origin Request Blocked: The Same Origin Policy disallows reading the remote resource at https://scrap.madiator.com/api/get-lbry-channel?v=2&url=**{channel-id}** (Reason: CORS header ‘Access-Control-Allow-Origin’ missing). Status code: 429.

when using odysee it does nothing.

kodxana commented 2 years ago

Should be fixed now. Was moving domain to new reverse proxy and it was not adding CORD header and that was making issues.

kodxana commented 2 years ago

@Relected If you want to support my work fell free to leave a tip at https://open.lbry.com/@Madiator2011:e/LBRYNexus:f

ghost commented 2 years ago

@kodxana ok so now it says this whenever i try to convert subs

429 Too Many Requests

50 per 1 hour

only 4 channels appeared, but i am 100% certain that there is more than that

devbrones commented 2 years ago

@Relected this is my bad, i implemented a cooldown in the api so it would not get flooded... Cant push a new version atm. Will later...

devbrones commented 2 years ago

@kodxana does the converter use wol-api too?

kodxana commented 2 years ago

@kodxana does the converter use wol-api too?

Yes if user select my hosted API.

devbrones commented 2 years ago

@kodxana what origin header does the extension have? Would mb be possible to add an exception for the plugin to let it circumvent cooldowns...

kodxana commented 2 years ago

I use nginx proxy and allowing cors from anywhere

devbrones commented 2 years ago

So there is no way of differentiating a standard request from a sub conv request?

devbrones commented 2 years ago

Cooldown fixed in commit 055fa90

ghost commented 2 years ago

@devbrones does that means that I can convert in peace now? edit: it now always stuck at 1.8% first try when choosing madiator as a URL resolver, and then the console sends hundreds of errors

like, literally hundreds of these

Cross-Origin Request Blocked: The Same Origin Policy disallows reading the remote resource at https://scrap.madiator.com/api/get-lbry-channel?v=2&url={channel_id}. (Reason: CORS request did not succeed). Status code: (null).

and also this GET https://scrap.madiator.com/api/get-lbry-channel?v=2&url={channel_id} CORS Missing Allow Origin

kodxana commented 2 years ago

I have updated the api with new limit. Try now. Also what version of plugin you have?

ghost commented 2 years ago

@kodxana im using 1.7.7

also the converter is stuck at 10% now

kodxana commented 2 years ago

@devbrones

kodxana commented 2 years ago

@Relected I think I know what is happening. My current setup is: Extension ------> Reverse Proxy ------> API Server API had hardcoded limit of 200 calls per day. Issue is that all request goes via reverse proxy and that makes so my ip send requests to api server and it was making my proxy being ratelimited. Now I edited code to add huge limit so it should work now fine.

kodxana commented 2 years ago

Published fix https://github.com/LBRYFoundation/Watch-on-LBRY/commit/bd33aa833f780b15c47bb9b9030921c1d451aa29 Soon wil be out on firefox with version 1.7.8

ghost commented 2 years ago

@kodxana i have updated the extension to the latest version now (1.7.8), It's now always stuck at exactly 88.6% every time

kodxana commented 2 years ago

Error logs?

devbrones commented 2 years ago

@kodxana no need to change rate limit! pull the newest version of wol-api

devbrones commented 2 years ago

it should fix proxy ip passthrough

ghost commented 2 years ago

@kodxana idk what this is, its stuck like that odysee sub

kodxana commented 2 years ago

404 is return when the Channel is not found by API

ghost commented 2 years ago

@kodxana well its still stuck at this percentage and it doesnt seem to progress at all, i left it for 15 minutes and its still the same, at least it should show the channels the have been found while its converting

kodxana commented 2 years ago

@kodxana well its still stuck at this percentage and it doesnt seem to progress at all, i left it for 15 minutes and its still the same, at least it should show the channels the have been found while its converting

Send me your subscription file to admin@madiator.com

ghost commented 2 years ago

@kodxana i fell a lil but uncomfortable sending you the whole file, can i send just a small portion of it instead to the email? or even leave a bit of it in this issue?

kodxana commented 2 years ago

What about remote call via Jitsi, Discord etc?

ghost commented 2 years ago

@kodxana thats fine, my discord is rTerm#7406