search

LBRYFoundation / Watch-on-LBRY

Plugin for web browser that automatic check if YouTube video is on LBRY
GNU General Public License v3.0
79 stars 19 forks source link

Redirection no longer working on Brave #56

Closed theJoshMuller closed 3 years ago

theJoshMuller commented 3 years ago

Describe the bug A couple weeks ago redirection was working fine on my Brave installation, but sometime recently it has stopped working. The plugin says it's on, but no redirection is happening. I attempted switching between lbry.tv and odysee.com, as well as turning the plugin on/off, but no luck. Seems to work fine on Firefox. I attempted using the plugin on a new Brave "person"/"account"/"workspace" (with no plugins installed), and it didn't work there either, so it doesn't seem to be a plugin conflict.

To Reproduce Steps to reproduce the behavior:

  1. Open Brave
  2. Navigate to a YouTube video synced to the LBRY network (i.e. this one)

Expected behavior Redirection to equiv video on LBRY network (i.e. this one from the example above).

Desktop:

henk717 commented 3 years ago

Also currently noticing this on Brave, but only partially. Using the App setting will get it to attempt to redirect to the APP (Which triggers the bug i filed yesterday) if you are on a Odysee or LBRY page. But the youtube redirects and the website button are no longer working. This might be broader to other browsers than brave as this could be a YouTube or Chromium issue.

cytsunny commented 3 years ago

Same here is ubuntu 20.04

And I have the redirect not working on both Brave and Chrome.

Aenigma commented 3 years ago

So the problem results in a CORS related issue. We can workaround this by by doing the fetch in the background script and then making sending the data back to the content scripts.

TheGhostHybrid commented 3 years ago

Can confirm that redirection does not work on Vivaldi. Currently running Manjaro, same version as OP.

henk717 commented 3 years ago

Did this fix land in the public build yet? Because i am still not getting any redirects or Watch on LBRY buttons on YouTube.

theJoshMuller commented 3 years ago

Same as @henk717 . Problem persists in Brave

kodxana commented 3 years ago

Did this fix land in the public build yet? Because i am still not getting any redirects or Watch on LBRY buttons on YouTube.

Same as @henk717 . Problem persists in Brave

Published update to web store and firefox. Should be out soon.

theJoshMuller commented 3 years ago

Confirming: current version of plugin on Chrome Web Store has solved this problem 👍🏽