search

LBeaudoux / tatoebatools

A library for fetching and reading Tatoeba's weekly exports
MIT License
20 stars 4 forks source link

Fix setup.py on Windows and unpin SQLAlchemy #14

Closed Vuizur closed 1 year ago

Vuizur commented 1 year ago

This PR fixes a crash on Windows when installing from setup.py (because utf-8 is not the default encoding on Windows). It also unpins SQLAlchemy, which I think was a typo. (At least all tests and the example from the README still work with the newest SQLAlchemy.)

LBeaudoux commented 1 year ago

@Vuizur Thanks for this PR, I really appreciate it.

The tests of the CI workflow have passed on GitHub Actions. It all sounds good to me.

Note that test.py – a file containing integration tests that I run locally on Ubuntu – is broken due to the unpinning of SQLAlchemy. It will be fixed in an other PR.

Vuizur commented 1 year ago

@LBeaudoux Thanks for the merge!