Closed LBlend closed 2 years ago
I should probably have done this before submitting the review, but i ran into an issue trying to build the branch locally:
The repo uses a pre-release version of tensorflow which is no longer on PyPi: tensorflow==2.8.0rc0 Tensorflow 2.8.0 is already out, so I think we should switch to that, assuming that there is no issue with the existing code. This is the one thing I have found so far which should be changed before merging
I applied the changes that you've requested and it should be working now. At least it does on my machine™️, and on Docker.
I would appreciate if you could make a final attempt at running it locally before merging. Other than that, I think we're good to go! 😁
Thanks for the review! 😊
I think it looks good now! Wasnt able to run it with docker, I think there is an issue with teh installation, but if you have tried it on 2 computers, we're all covered
I'll have one more look at it before I merge. If it's good on my end I'll merge it
Thanks agains btw!
Works fine on my machines so I'm guessing it's good
A complete rewrite of the backend using FastAPI instead of flask. Now sporting better docker support and as well as (almost) fully typed code.
It's been a while since I last took a look at it but it should be working fine. I just want a final review to make sure everything is ok.
I'm planning on making some variable names more semantic and changing the interface a bit to reflect that, but that'll be a task for another release. I want this version number to be compatible with its frontend counterpart.
Closes #44 Closes #45