Monte Carlo seems to use incorrect demand amounts - Githubissues

LCA-ActivityBrowser / activity-browser

GUI for brightway2

GNU Lesser General Public License v3.0

149 stars 57 forks source link

Monte Carlo seems to use incorrect demand amounts #1087

Open cmutel opened 1 year ago

cmutel commented 1 year ago

Updating AB

[X] Yes, I have updated AB and still experience this issue

What happened?

Monte Carlo loads a calculation setup
It sets func-units to be the demand dictionary in the calculation setup
This demand dictionary can have whatever amounts it wants
The LCA constructor calls the property func_units_dict
The property func_units_dict uses the amount 1 instead of the defined amount for each product
Users get incorrect results

Relevant errors

Irrelevant

Operating system

MacOS

Conda environment

Irrelevant

cmutel commented 1 year ago

@bsteubing We will need to rewrite most of the MC code during the adaptation for BW25, so this is low priority.