Add caching of Sankey results

LCA-ActivityBrowser / activity-browser

GUI for brightway2

GNU Lesser General Public License v3.0

134 stars 50 forks source link

Add caching of Sankey results #1117

Closed marc-vdm closed 6 months ago

marc-vdm commented 8 months ago

Resolve #1112 + Remove unused code

@mrvisscher: can be closed as squashcommit

Checklist

[x] Keep pull requests small so they can be easily reviewed.
[x] Update the documentation, please follow the numpy style guide
[x] Categorize the PR by setting a good title and adding one of the labels: bug, feature, ui, change, documentation, breaking, ci as they show up in the changelog
[x] Link this PR to related issues by using closing keywords.
[x] Request a review from another developer.

marc-vdm commented 8 months ago

@mrvisscher No hurries with this. First get started with other things, but whenever you're ready.

You can see in the contributing guidelines how to review a PR.

You can add my fork to your IDE as a remote and pull this branch and run it to see the code in action.

coveralls commented 8 months ago

coverage: 50.026% (-0.03%) from 50.055% when pulling 3caff4c96f534a1d8100fb4bb974901c0b572693 on marc-vdm:sankey_caching into d5b9e75a56355f7ca9f90898de7d7908f7d28344 on LCA-ActivityBrowser:master.

github-actions[bot] commented 6 months ago

This issue has been implemented in the new release of Activity Browser 🚀 (version 2.9.3), you can get the new version by updating Activity Browser.

🤖beep boop! I'm a bot and this message was an automated action. If updating does not make sense for this issue, just ignore this.