Add - copy on impact category copy

LCA-ActivityBrowser / activity-browser

GUI for brightway2

GNU Lesser General Public License v3.0

134 stars 50 forks source link

Add - copy on impact category copy #1136

Closed mrvisscher closed 7 months ago

mrvisscher commented 7 months ago

Instead of adding another field, TupleNameDialog now appends - Copy to the last tuple item, which is more intuitive for the end-user. If the name ends up not being unique, an error dialogue is displayed (this was already implemented)

Closes #1133

Demo

impact-categories

Checklist

[x] Keep pull requests small so they can be easily reviewed.
[x] Update the documentation, please follow the numpy style guide
[ ] Update tests.
[x] Categorize the PR by setting a good title and adding one of the labels: bug, feature, ui, change, documentation, breaking, ci as they show up in the changelog
[x] Link this PR to related issues by using closing keywords.
[x] Request a review from another developer.

coveralls commented 7 months ago

coverage: 50.044% (-0.007%) from 50.051% when pulling fa4f7887598cbfcc09b5a375439a054f754db419 on mrvisscher:impact-category-copy into d23a9d24e1079a09d22531a43d79a4aca8163161 on LCA-ActivityBrowser:master.

marc-vdm commented 7 months ago

@mkvdhulst What do you think of the above GIF? Is that what you're looking for?

To me this looks like a good improvement for sure, but if you have additional suggestions, let us know!

Also, if you feel comfortable with git, you can try the changes from here, but no need, the GIF shows it all.

mkvdhulst commented 7 months ago

That looks great!

If I understand correctly, you can still change the name to something else than adding " - copy"? In the basis, adding " - copy" would suffice, but being allowed to change that name can help in organizing methods and distinguishing multiple copies.

mrvisscher commented 7 months ago

Thanks for the feedback @mkvdhulst,

If I understand correctly, you can still change the name to something else than adding " - copy"?

Yes! You can change it to whatever you want. - copy is just a suggestion

marc-vdm commented 7 months ago

@mkvdhulst great! This will be available in 2.9.3, I expect we will have it ready early December.

@mrvisscher I'll write this here so I don't forget, but please still add the following:

[x] Reorder contextMenu items so Expand... and Collapse... are on top
[x] Add menu.addSeparator() underneath those two (see teams for Screenshot example).

github-actions[bot] commented 6 months ago

This issue has been implemented in the new release of Activity Browser 🚀 (version 2.9.3), you can get the new version by updating Activity Browser.

🤖beep boop! I'm a bot and this message was an automated action. If updating does not make sense for this issue, just ignore this.