LCA-ActivityBrowser / activity-browser

GUI for brightway2
GNU Lesser General Public License v3.0
134 stars 50 forks source link

Duplicating IC bugs #1164

Open marc-vdm opened 7 months ago

marc-vdm commented 7 months ago

Updating AB

What happened?

2 bugs related to:

Sanitized character input

When duplicating this: image

There is a , in the name, however, user cannot input , themselves (or put it back after backspace)

IMO any character should be allowed, we can just sanitize by applying str(input)

Empty strings allowed

image

I see empty strings are allowed. It seems that when not all inputs are empty, the tuple just ignores the empty strings, that's great, however, if all inputs are empty, user could create a nameless impact category, this should not be allowed.

I suggest checking for this and putting self.buttons.Ok.setEnabled(False) if all are empty (not sure if this code works exactly, but something like it should)

What happens when I add the 'empty IC' duplicated from selected LCI results, water, BOD is this: image It seems only the first row is read empty

I think only the first changed row is recorded. Personally, I think it'd be good to record all changes, allowing people to make their own categories and sub categories etc.

Relevant errors

No response

Operating system

Windows 10

Conda environment

No response