Reference flows equal to 0 aren't allowed to calculate anymore.

marc-vdm commented 6 months ago

It was not allowed for the sum of reference flows in a calculation setup to be equal to 0. This was an error.

AB should instead check for reference flows that are 0 themselves (needing 0 of something will by definition have 0 impact, so should not be allowed in calculation).

AB now checks for any ==0 reference flows and shows an appropriate error message informing user.

Checklist

[x] Keep pull requests small so they can be easily reviewed.
[x] Update the documentation, please follow the numpy style guide.
[ ] Update tests.
[x] Categorize the PR by setting a good title and adding one of the labels: bug, feature, ui, change, documentation, breaking, ci as they show up in the changelog.
[ ] Link this PR to related issues by using closing keywords.
[x] Request a review from another developer.

coveralls commented 6 months ago

coverage: 50.392% (+0.06%) from 50.33% when pulling 04dd246d65822efc58440a3c24ce5baf3a488db1 on marc-vdm:calculation_setup_0_msg into 51566ac32c80bbc40d4f976084dbb1a8ee88f985 on LCA-ActivityBrowser:master.

github-actions[bot] commented 6 months ago

This issue has been implemented in the new release of Activity Browser 🚀 (version 2.9.3), you can get the new version by updating Activity Browser.

🤖beep boop! I'm a bot and this message was an automated action. If updating does not make sense for this issue, just ignore this.

LCA-ActivityBrowser / activity-browser

Reference flows equal to 0 aren't allowed to calculate anymore. #1170

Checklist