Timezone sorting and empty databases - Githubissues

LCA-ActivityBrowser / activity-browser

GUI for brightway2

GNU Lesser General Public License v3.0

134 stars 50 forks source link

Timezone sorting and empty databases #1179

Closed marc-vdm closed 5 months ago

marc-vdm commented 6 months ago

Updating AB

[X] Yes, I have updated AB and still experience this issue

What happened?

To reproduce:

Get project with default data installed
Create database, leave empty
re-start AB or switch project
AB shows the default data import button now.

A new and empty database does not have a modified time, meaning the conversion below fails, as empty string cannot be converted to the given format: https://github.com/LCA-ActivityBrowser/activity-browser/blob/f22833f1029d6487eb5261250173119f5ad521f3/activity_browser/ui/tables/models/inventory.py#L43

Solution:

[ ] When the above fails, add current time to that row.
[ ] remove unused variable
[ ] Perhaps add actual modified time/date to tooltip as well?

Relevant errors

No response

Operating system

Windows 10

Conda environment

No response

github-actions[bot] commented 5 months ago

[!NOTE] This issue has been implemented in the new release of Activity Browser 🚀 (version 2.9.4), you can get the new version by updating Activity Browser.

Do you want to be notified of new releases of Activity Browser? Subscribe to our updates mailing list ✉.

🤖beep boop! I'm a bot and this message was an automated action. If updating does not make sense for this issue, just ignore this.