LCA-ActivityBrowser / activity-browser

GUI for brightway2
GNU Lesser General Public License v3.0
134 stars 50 forks source link

Failing Dev release with multiple merges on one day #1193

Closed marc-vdm closed 5 months ago

marc-vdm commented 5 months ago

Issue

@haasad Sorry to bother you again. We noticed yesterday, but also just now, that the GH action creating a dev release fails when a merge has already been made that day.

What seems to fail is the (confirmation of?) deletion of the existing release with current date on the bsteubing channel. However, when checking this link, the file's been deleted, but the error's indicating that deleting failed because the file doesn't exist.

Yesterday both @mrvisscher and I were watching the dev channel online, and we're sure that the release came online after the first merge, but then was deleted through the failed action.

This problem is not super critical, as 1) the dev release is only used for testing by us, users don't really use it anymore 2) we can re-run the action and it will succeed as there's no file to delete. However, something doesn't seem right.

haasad commented 5 months ago

Could be a change in how anaconda upload --force works, or we just never really encountered that before. I made a PR with a proposal to change the versioning to TAGdevX, where TAG is the latest tag and X is the number of commits since the last tag, e.g 2.9.4dev2 or similar.

mrvisscher commented 5 months ago

It's not fully solved yet as @marc-vdm noticed. Right now releases with the new versioning scheme are considered to be 'older' than the 20xx.xx.xx releases because conda sorts them alphabetically. If I understand this page correctly we should be able to remedy this by setting an epoch using n! in front of the release. I'll quickly create a PR and add you as reviewer @haasad

haasad commented 5 months ago

another option would be to remove the main labels on https://anaconda.org/bsteubing/activity-browser-dev/files for all the older 2024.x etc, then conda won't consider them unless you tell it to install that exact version IIRC

mrvisscher commented 5 months ago

Oh, that may be easier. That's probably something @bsteubing could try out then I guess, as it is in his account?

haasad commented 5 months ago

I have access with my account on anaconda.org. @bsteubing once added me as a contributor to his channel. It would probably make sense for you and @marc-vdm to also create an account there and Bernhard adding you as contributors.

I changed the label of all ABdev versions with the old versioning scheme from main to outdated.

conda search --override -c bsteubing activity-browser-dev
Loading channels: done
# Name                       Version           Build  Channel             
activity-browser-dev       2.9.4dev1            py_0  bsteubing           
activity-browser-dev       2.9.4dev2            py_0  bsteubing 
conda search --override -c bsteubing/label/outdated activity-browser-dev
Loading channels: done
# Name                       Version           Build  Channel             
activity-browser-dev      2019.03.22            py_0  bsteubing/label/outdated
activity-browser-dev      2019.04.08            py_0  bsteubing/label/outdated
activity-browser-dev      2019.04.12            py_0  bsteubing/label/outdated
activity-browser-dev      2019.04.15            py_0  bsteubing/label/outdated
activity-browser-dev      2019.05.15            py_0  bsteubing/label/outdated
activity-browser-dev      2019.05.16            py_0  bsteubing/label/outdated
activity-browser-dev      2019.05.17            py_0  bsteubing/label/outdated
<...>
activity-browser-dev      2023.12.13            py_0  bsteubing/label/outdated
activity-browser-dev      2023.12.17            py_0  bsteubing/label/outdated
activity-browser-dev      2023.12.20            py_0  bsteubing/label/outdated
activity-browser-dev      2023.12.21            py_0  bsteubing/label/outdated
activity-browser-dev      2023.12.22            py_0  bsteubing/label/outdated
activity-browser-dev      2024.01.08            py_0  bsteubing/label/outdated
activity-browser-dev      2024.01.09            py_0  bsteubing/label/outdated
mrvisscher commented 5 months ago

Yep, this seems to have fixed it. Fantastic, thanks again voor your insight and help @haasad!