LCA-ActivityBrowser / activity-browser

GUI for brightway2
GNU Lesser General Public License v3.0
134 stars 50 forks source link

Fix AB crash after two calculations #1228

Closed mrvisscher closed 4 months ago

mrvisscher commented 4 months ago

Fixes an issue where the AB crashes after you've done two LCA calculations and then start another QThread. By supplying parents to QtWebEngine objects the issue is fixed, probably because they are now properly cleaned up after their parent widget has been closed.

Checklist

coveralls commented 4 months ago

Coverage Status

coverage: 50.688%. remained the same when pulling 098f6a96c9ffa58d6d4deb810083dedd19e817d5 on mrvisscher:sankey-thread-crash-fix into 30a81c0220c523e029ae05c99cd9b6e874aa88c8 on LCA-ActivityBrowser:master.