LCA-ActivityBrowser / activity-browser

GUI for brightway2
GNU Lesser General Public License v3.0
134 stars 50 forks source link

CS Controller updates all calculation setups when a database is deleted #1251

Closed mrvisscher closed 1 month ago

mrvisscher commented 3 months ago

When a database and their activities are deleted, calculation setups should reflect this by removing any affected functional units. This does already happen automatically (?) for removing individual flows. With this PR this also happens for database deletions by connecting the CS Controller to the delete_database_confirmed signal.

Checklist

coveralls commented 3 months ago

Coverage Status

coverage: 50.611% (-0.04%) from 50.652% when pulling 97d9af610734e8bdaf87a6b83f57c08e5328de9d on mrvisscher:fix-cs-update-on-db-delete into ffa5ad8495fcf3743a0ffe5b56cc225dd0d6b7d6 on LCA-ActivityBrowser:master.

mrvisscher commented 1 month ago

Not compatible with controller rework