Migrate to `bw_graph_tools`

LCA-ActivityBrowser / activity-browser

GUI for brightway2

GNU Lesser General Public License v3.0

144 stars 55 forks source link

Migrate to `bw_graph_tools` #1302

Closed cmutel closed 3 months ago

cmutel commented 3 months ago

Feature request

The new library is 2.5 compliant, makes fewer assumptions (meaning better support for multifunctionality or process/product splits), and is actually tested: https://github.com/brightway-lca/bw_graph_tools.

The previous code was here, and returned a less-than-friendly result object.

The new code returns dataclasses which are at least explained.

The new code also returns elementary flows, which was considered an improvement in #844.

cmutel commented 3 months ago

Migration would need to happen anywhere NewNodeEachVisitGraphTraversal is used; can start with sankey_navigator.py.

ughstudios commented 3 months ago

I think I have a pretty good idea of what needs to be done now. But, let's chat when you are able to later today.

marc-vdm commented 3 months ago

Closing as taken over by Cauldron