LCA-ActivityBrowser / activity-browser

GUI for brightway2
GNU Lesser General Public License v3.0
134 stars 50 forks source link

Format and lint with black and isort #1306

Closed jsvgoncalves closed 2 weeks ago

jsvgoncalves commented 3 weeks ago

Description

This PR formats and lints the whole codebase with black and isort. Ideally we should install CI/CD checks as well as a pre-commit hook, but at least for now this adds some consistency to the codebase.

More info on ignoring commits in the blame: https://docs.github.com/en/repositories/working-with-files/using-files/viewing-a-file#ignore-commits-in-the-blame-view

[!CAUTION] Do not change the formatting commit or its id will change and the ignore-revs won't work. Merging or rebasing is ok.

Checklist

mrvisscher commented 3 weeks ago

Hi @jsvgoncalves!

Before I can merge, please fix the breaking import order. Activity Browser won't launch with this PR right now because of ImportError's causes by circular imports.

Thanks!