LCA-ActivityBrowser / activity-browser

GUI for brightway2
GNU Lesser General Public License v3.0
152 stars 58 forks source link

AB hangs indefinitely when importing database without network connection #1408

Open Q-Quan opened 6 days ago

Q-Quan commented 6 days ago

Updating AB

What happened?

When no network is available (e.g. Wi-Fi is turned off), importing a database via the wizard naturally does not work. In the terminal, this results in a requests.exceptions.ConnectionError. However, in the GUI, this has no effect: the login prompt stays open and the cursor keeps spinning. The prompt can be closed, and the AB can be used after that, but the cursor will remain spinning even then.

More generally, other exceptions during the importing process (e.g. from using credentials that are valid but unlicensed) result in the same behaviour.

I would expect some graceful handling of the issue (e.g. an error alert) when this happens.

Relevant errors

No response

Operating system

Windows 11

Conda environment

No response

marc-vdm commented 5 days ago

@mrvisscher Also add to the safe fetch

Q-Quan commented 5 days ago

I also ran into an instance where, using valid and licensed credentials, the version dropdowns did not populate, and I could proceed to the import step with empty values. This yielded a terminal error, but again no feedback in the GUI. Cannot reproduce this again, though.