LCA-ActivityBrowser / activity-browser

GUI for brightway2
GNU Lesser General Public License v3.0
142 stars 54 forks source link

Potentially unused dependency #316

Closed tur-ium closed 4 years ago

tur-ium commented 4 years ago

Hi, I am new to activity-browser and Brightway 2 so apologies as I am not too familiar with the code structure. I noticed when installing that BeautifulSoup is listed as a dependency when installing via conda but it doesn't seem to be used in the code. Maybe I am wrong as I am just using GitHub search, but reducing the number of dependencies would be handy for people running on limited disk space.

dgdekoning commented 4 years ago

Hey @tur-ium, you are indeed correct in that the activity browser itself doesn't make use of the BeautifulSoup dependency. That dependency is being used by the eidl package (EcoInventDownLoader) to sniff around the ecoinvent website page and find possible versions and types of datasets to download.

In turn the eidl dependency is used by the activity browser to allow users to import ecoinvent directly.

tur-ium commented 4 years ago

Aha ok! Thanks for clarifying!