LCA-ActivityBrowser / activity-browser

GUI for brightway2
GNU Lesser General Public License v3.0
144 stars 57 forks source link

Monte Carlo calculation results not making sense #821

Open MaximeAgez opened 2 years ago

MaximeAgez commented 2 years ago

Hi, A colleague of mine performed a Monte Carlo analysis including parameter uncertainty and it yields results that do not make sense.

Explanation: The stochastic results gives something close to zero:

image

The Monte Carlo including only technosphere uncertainty yields results that make sense:

image

Once parameter uncertainty is added it goes off the tracks completely:

image

You will tell me that there is an issue in the uncertainty definitions for parameters, except I did not yet define any uncertainty for parameters.

image

I will try to run the Monte Carlo analysis in brightway2 and update the post, to see if it's bw2 going crazy of if it's an issue in the implementation in AB.

simb-sdu commented 2 years ago

from my understanding, uncertainty can be defined in your parameters as well as in your activity exchanges. I had some trouble working modelling with activity parameters, maybe this gives some errors for you as well? It seemed to me that some old parameter data stored somewhere could be mixed and messed totally up. I would suggest to make a brand new activity/product system to test this.

MaximeAgez commented 2 years ago

I made a new database in which I only had one activity directly calling an ecoinvent process (i.e., a 1 in the "amount" cell). When performing the Monte Carlo with "technosphere" and "parameters" checked the results look fine.

When I use the formula however (i.e., a 1 in the "formula" cell), Monte Carlo goes crazy with the "parameters" checked.

Since it's the same process and same quantity called it should not have anything to do with remnants of parameters here and there.

simb-sdu commented 2 years ago

sounds very strange. I have strange issues with monte carlo too. what happens if you define technosphere uncertainty as "none"? foes it change the results depending on if you put 1 in amount or formula when "none" uncertainty?

Also, what happens if you define "none" uncertainty for all params

MaximeAgez commented 2 years ago

Same problems when using "No uncertainty" instead of "Undefined or unknown uncertainty"

lucas-sys-cmd commented 1 year ago

I think I met the same problem, too. After including uncertainty in my parameters, the LCA results were totally different. I've been stuck by this problem for several days.

madel91 commented 11 months ago

Hello,

I have been struggling with this problem for a long time. I tried many solutions that I can explain to anyone interested as workarounds but in vain. Finally, I had to abandon doing this type of Monte Carlo simulation with the software, and the alternative was developing n number of scenarios= Monte Carlo iterations and doing the random sampling of the parameters manually.

haasad commented 11 months ago

could this be caused by the problem described in #1087?

gpuigsamper commented 1 month ago

Hello,

I have recently met the same problem when including technosphere and parameter uncertainty in Monte Carlo simulation in AB. Monte Carlo simulation results look fine when excluding parameter uncertainty, but make no sense when including parameter uncertainty.

Do you have any update on this problem?

Thanks.