search

LCA-ActivityBrowser / activity-browser

GUI for brightway2
GNU Lesser General Public License v3.0
139 stars 54 forks source link

monte-carlo fixing seed is broken #850

Open marc-vdm opened 1 year ago

marc-vdm commented 1 year ago

When using monte-carlo and putting a seed value in the calculation, the results should always be the same. However, when hitting Run again, the results are different every time.

example: image

image

marc-vdm commented 1 year ago

@Zoophobus BW code needs to first be reviewed to see if this is actually broken or that we misunderstand the problem. In case of the latter, I think we need to add a tooltip to the Random seed field explaining what the seed actually means. Ideally we would also look for a way to implement an actual seed mechanism that we can use to set a seed to always get the same result when the same calculation setup is used on a different computer. Though I'm not sure this is possible due to OS/rng differences. If that is the case we could look for a way to at least have reproducable results on the same OS?