search

LCAS / CallARobot

A simple web interface to call a robot
MIT License
3 stars 10 forks source link

[BUG]: Inconsistent naming of GPS variables #25

Open nikolauswagner opened 3 months ago

nikolauswagner commented 3 months ago

Description of the bug

The variables in the GPS messages are named inconsistently (cf. the various declarations in callarobot/py), specifically this is an issue in the data sent here, as the longitude entry is called "long", which causes issues with my linter because of the identical datatype name. I think it would be good practice to have all the variables named the same in this file, e.g. "latitude" and "longitude".

Steps To Reproduce

Run pylint on callarobot.py

Additional Information

No response

nikolauswagner commented 3 months ago

I have no permissions to do this but happy for you to assign this to myself @marc-hanheide, however not sure if there is going to be any further fallout not obvious to me from renaming the variables as suggested.

marc-hanheide commented 3 months ago

what do you mean you don't have permission? Can't you open a PR?