Update LCAS branch with SAGA branch

[adambinch]

@marc-hanheide these are general improvements but you may not want this one https://github.com/LCAS/topological_navigation/pull/138/commits/8ce9ee5926b45a3ae2a1b11db9917b6404d40577 ?

[marc-hanheide]

Thanks for this. The problem here is that the defined unit tests, e.g., https://github.com/SAGARobotics/topological_navigation/blob/038b42ba04d6c6964f7a66c6a57433235f82ed4e/topological_navigation/tests/travel_time_estimator.test and https://github.com/SAGARobotics/topological_navigation/blob/038b42ba04d6c6964f7a66c6a57433235f82ed4e/topological_navigation/tests/navigation_scenarios.test are still defined to start the message_store which obviously is no longer installed. These also should be amended, also for SAGA's own CI, @adambinch @baardkrk , right?

[adambinch]

@Jailander can we make versions of these tests that do not rely on mongodb?

[Jailander]

Eek that might be complex let me take a look tomorrow. But it's more likely that we should have new tests.

[adambinch]

Ok to merge @marc-hanheide ?

[marc-hanheide]

it's more that you don't want that workflow,.right? cause it would try to push to your repo. so, I'd say revert the release commit in this PR

[adambinch]

@baardkrk can you remove those commits from this PR?

[baardkrk]

I'll remove the commits, however, won't they have to be removed every time we want to sync the saga commits to LCAS? Will this be done often in the future?

[adambinch]

I'll remove the commits, however, won't they have to be removed every time we want to sync the saga commits to LCAS? Will this be done often in the future?

[adambinch]

Sorry accidentally closed the PR

[adambinch]

I'll remove the commits, however, won't they have to be removed every time we want to sync the saga commits to LCAS? Will this be done often in the future?

Hope not :(

[adambinch]

Closing this as it is replaced by https://github.com/LCAS/topological_navigation/pull/139