search

LCAS / topological_navigation

The topological navigation framework
Apache License 2.0
32 stars 36 forks source link

Warning messages in map sanity check #23

Closed gpdas closed 3 years ago

gpdas commented 4 years ago

This line and this line in manager.py assume the node names doesn't contain any _s in the names. If there are _s in the node names, the split of e as origin and destination may not be as intended and the warning may not make sense.

This however works with our general naming convention WayPointXX, but not with WayPoint_XX.

This also doesn't break anything at this stage, as we use the sanity check only for validating the file/map is OK or not.

gpdas commented 4 years ago

@adambinch This may not be a priority, but just assigned it to you.

adambinch commented 4 years ago

ok no problem :)

On Fri, Jun 26, 2020 at 2:13 PM Gautham P Das notifications@github.com wrote:

@adambinch https://github.com/adambinch This may not be a priority, but just assigned it to you.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/LCAS/topological_navigation/issues/23#issuecomment-650171517, or unsubscribe https://github.com/notifications/unsubscribe-auth/AF3YS3WFKAIKUV6CT4OLPBTRYSNGDANCNFSM4OJKE52A .

-- Adam Binch | Robotics Engineer SAGA ROBOTICS LTD // THORVALD Think Tank Lincoln LN6 7FL Office: 01522837293 Mobile Phone +44 7940 835 628

adambinch commented 4 years ago

My latest commit 6b12111 should fix this @gpdas

gpdas commented 3 years ago

Already addressed and merged.