LCAS / topological_navigation

The topological navigation framework
Apache License 2.0
31 stars 36 forks source link

adding route cache #92

Closed Jailander closed 1 year ago

marc-hanheide commented 3 years ago

4 hours can be a bit short… can we give a higher default (or make it configurable)? For @ZuyuanZhu work, he probably would want it for much longer to run many different experiments easily. one worry, of course is that the cache should include the map in its hash, as otherwise we’ll get awful side effects once called with a different map, right?

Jailander commented 3 years ago

yes, that was my train of thought when doing it rather short, I did think about deleting the cache when creating the object but then Iwasn't sure if that would have any side effect on @ZuyuanZhu framework

Jailander commented 3 years ago

I will try to have a play with making hashes with the map name so this is not a problem, however you might still have problems if you modify the map

marc-hanheide commented 3 years ago

due to these side effects, I think this really needs to be explicitly enabled and not on by default.

Jailander commented 3 years ago

Yeah, good call I will add that ASAP

ZuyuanZhu commented 3 years ago

Just tested the cachier. Unfortunately, the result is not good. With 1 polytunnel, we can get the result within 2.7s without cachier, but after adding cachier, almost 1 hour passed and I still haven't got the result.

The cachier is definitely working as I found the cache file size .topological_navigation.route_search.search_route keeps changing and the des simulation logs information very very slow.

I'll stop the simulation now and try the cachier on the full CHF map to see whether we can get the time back.

marc-hanheide commented 1 year ago

I guess this is not longer valid, @ZuyuanZhu / @Jailander ? Please reopen if not deprecrated and update.

ZuyuanZhu commented 1 year ago

I guess this is not longer valid, @ZuyuanZhu / @Jailander ? Please reopen if not deprecrated and update.

Yes, no longer needed. @adambinch fixed in #96