Add AnechoicRoom class - Githubissues

LCAV / pyroomacoustics

Pyroomacoustics is a package for audio signal processing for indoor applications. It was developed as a fast prototyping platform for beamforming algorithms in indoor scenarios.

https://pyroomacoustics.readthedocs.io

MIT License

1.35k stars 419 forks source link

Add AnechoicRoom class #224

Closed duembgen closed 1 year ago

duembgen commented 3 years ago

This pull request reopens #160, now against the new version of pyroomacoustics.

This will close issue #13.

I am working on polishing it and will remove the "WIP" tag when done.

[x] Are there docstrings ? Do they follow the numpydoc style ?
[x] Have you run the tests by doing nosetests or py.test at the root of the repo ?
[x] Have you checked that the doc builds properly and that any new file has been added to the repo ? How to do that is covered in the documentation.
[x] Is there a unit test for the proposed code modification ? If the PR addresses an issue, the test should make sure the issue is fixed.
[x] Last but not least, did you document the proposed change in the CHANGELOG file ? It should go under "Unreleased".

fakufaku commented 2 years ago

Hi @duembgen ! What is the status on this pull request ? If it is good, I could just pull it in. The tests are failing now, so maybe a merge or something is needed.

duembgen commented 2 years ago

Hi @fakufaku thank you for your comments! I am finalizing the pull request now. Will remove the Eigen comment if it is fixed by doing a recursive clone. Do you have any preference on how / if to mention the AnechoicRoom class in the documentation? I added another section called Free-field simulation in the room doc file, but happy to change that.

duembgen commented 2 years ago

Regarding the CHANGELOG, would you like me to be more specific than Added AnechoicRoom class?

EliasBrohammer commented 2 years ago

sorry for bursting into your conversation: Just yesterday I created a script using the idea from issue #13 (max_order=0 for the room creation). I will try the new room as soon as it's ready and give you feedback!

EliasBrohammer commented 1 year ago

Just wanted to ask, how the status on this pull-request is? :)

duembgen commented 1 year ago

@fakufaku I have simplified the example, I hope that's roughly what you had in mind. Feel free to change anything to your liking and merge as soon as you are satisfied. @EliasBrohammer sorry for the late reply.

fakufaku commented 1 year ago

@duembgen Sorry it took me so long to merge this! Thanks for your contribution!!! 🙏