Pyroomacoustics is a package for audio signal processing for indoor applications. It was developed as a fast prototyping platform for beamforming algorithms in indoor scenarios.
The DIRPat pull request #302 still requires some work.
In particular, it has added a lot of complexity to room.py that was already very complex. This pull request will thus break down room.py into several files.
Thanks for sending a pull request (PR), we really appreciate that! Before hitting the submit button, we'd be really glad if you could make sure all the following points have been cleared.
Please also refer to the doc on contributing for more details. Even if you can't check all the boxes below, do not hesitate to go ahead with the PR and ask for help there.
[ ] Are there docstrings ? Do they follow the numpydoc style ?
[ ] Have you run the tests by doing nosetests or py.test at the root of the repo ?
[ ] Have you checked that the doc builds properly and that any new file has been added to the repo ? How to do that is covered in the documentation.
[ ] Is there a unit test for the proposed code modification ? If the PR addresses an issue, the test should make sure the issue is fixed.
[ ] Last but not least, did you document the proposed change in the CHANGELOG file ? It should go under "Unreleased".
The DIRPat pull request #302 still requires some work.
In particular, it has added a lot of complexity to
room.pythat was already very complex. This pull request will thus break down room.py into several files.Thanks for sending a pull request (PR), we really appreciate that! Before hitting the submit button, we'd be really glad if you could make sure all the following points have been cleared.
Please also refer to the doc on contributing for more details. Even if you can't check all the boxes below, do not hesitate to go ahead with the PR and ask for help there.
nosetestsorpy.testat the root of the repo ?Happy PR :smiley: