metrics.py: fix compatibility with scipy >=1.13

mattpitkin commented 1 month ago

As of scipy v1.13, the hann window has been removed from scipy.signals and is now only accessible through scipy.signals.windows. This PR accounts for this move so that pyroomacoustics will work with the latest scipy versions.

Closes #342

[ ] Are there docstrings ? Do they follow the numpydoc style ?
[ ] Have you run the tests by doing nosetests or py.test at the root of the repo ?
[ ] Have you checked that the doc builds properly and that any new file has been added to the repo ? How to do that is covered in the documentation.
[ ] Is there a unit test for the proposed code modification ? If the PR addresses an issue, the test should make sure the issue is fixed.
[ ] Last but not least, did you document the proposed change in the CHANGELOG file ? It should go under "Unreleased".

Happy PR :smiley:

GaetanLepage commented 1 month ago

Thank you for this fix. Using pyroomacoustics with the latest scipy is indeed broken.

fakufaku commented 3 weeks ago

@mattpitkin Thank you so much for taking care of this. LGTM

GaetanLepage commented 3 weeks ago

Thanks for the fix ! @fakufaku could you please consider making a release for this fix to be available to a broader audience ?

fakufaku commented 3 weeks ago

@GaetanLepage Yes of course! I am working on this right now.

fakufaku commented 3 weeks ago

@mattpitkin v0.7.4 is out! Thanks for the contribution!

mattpitkin commented 3 weeks ago

Cool. Glad to be of help.

Just a quick note to say that the date for the new release in the changelog file needs to be updated!

fakufaku commented 3 weeks ago

Just a quick note to say that the date for the new release in the changelog file needs to be updated!

Oups!! Thanks for letting me know.

LCAV / pyroomacoustics

metrics.py: fix compatibility with scipy >=1.13 #344