LCD344 / Kirby-userManager-panel-extention

13 stars 2 forks source link

Can't edit user with . #3

Open CydGoblin opened 6 years ago

CydGoblin commented 6 years ago

If the username as a dot on it you can't edit it, it says their page doesn't exist

LCD344 commented 6 years ago

Could you please give some steps to reproduce this? I've been using this in many of my projects where usernames are emails, and they work without a problem (emails have . in them)

CydGoblin commented 6 years ago

thanks for the help. This is what I tried today:

Did the same with gulp-connect-php and got this when creating the user with an email as username

Fatal error: Uncaught Exception: The user account could not be found in /kirby2/kirby/core/user.php:24 Stack trace: #0 /kirby2/kirby/core/users.php(26): UserAbstract->__construct('test@startup....') #1 /kirby2/kirby/core/site.php(304): UsersAbstract->__construct() #2 /kirby2/panel/app/src/panel/installer.php(11): SiteAbstract->users() #3 /kirby2/site/plugins/userManager/Panel/Router/filters.php(28): Kirby\Panel\Installer->isCompleted() #4 /kirby2/kirby/vendor/getkirby/toolkit/helpers.php(282): lcd344\Panel\Router\{closure}(Object(Obj)) #5 /kirby2/kirby/vendor/getkirby/toolkit/lib/router.php(189): call(Object(Closure), Array) #6 /kirby2/kirby/vendor/getkirby/toolkit/lib/router.php(239): Router->filterer(Array, Object(Obj)) #7 /kirby2/kirby/core/user.php on line 24

Got the same error with mac's build in php server

LCD344 commented 6 years ago

@Turqueso - Hi, I'm very sorry for not answering before, I didn't get the notification for it.

Quick check shows that users with "non normal" names (illegal characters in kirby) would only work with custom user folder. Seems that this is a problem with the new version of kirby, where it doesn't like having any file with illegal characters in the accounts folder, even if its not the current logged user.

if you define a custom user folder - c::set("userManager.folder","users"); for example, this will work only for front end users though.

I will look if I can make changes to this, but I suspect this is a kirby thing, not a userManager Thing