search

LCOGT / neoexchange

NEO observing portal
GNU General Public License v3.0
7 stars 1 forks source link

Fixes Issue 490 #491

Closed talister closed 4 years ago

talister commented 4 years ago

Changes the templates loaded in 'admin' to match rename which happened in Django 3.0. 6 characters of fix, 92 lines of added FT... Fixes #490

jchate6 commented 4 years ago

Doesn't seem to be related to this PR, but I'm getting a failed test in neox.tests.test_schedule_cadence.ScheduleCadence.test_can_schedule_cadence Looks like it might be a mock time issue? I haven't looked at it closely.

talister commented 4 years ago

On Thu, Oct 1, 2020 at 1:40 PM Joseph Chatelain notifications@github.com wrote:

Doesn't seem to be related to this PR, but I'm getting a failed test in neox.tests.test_schedule_cadence.ScheduleCadence.test_can_schedule_cadence Looks like it might be a mock time issue? I haven't looked at it closely.

Yes that breaks on python 3.7, don't know why. The MockDatetime just doesn't...

—

You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/LCOGT/neoexchange/pull/491#issuecomment-702384928, or unsubscribe https://github.com/notifications/unsubscribe-auth/AANRU7FLQ7LTHTEPWIWKFYTSITSKRANCNFSM4SA3CFNQ .

-- Dr Tim Lister, Staff Astronomer +1 805 880 1989

jchate6 commented 4 years ago

Yes that breaks on python 3.7, don't know why. The MockDatetime just doesn't... —

This is new to master. This doesn't break on my MuSCAT branch. I'll take a look and see if I can tell what's up.

jchate6 commented 4 years ago

Looks like you updated the values from the ones I get a few days ago? https://github.com/LCOGT/neoexchange/commit/12f8541b8020e633c4962b27895344ca4cb4535b

talister commented 4 years ago

On Thu, Oct 1, 2020 at 2:19 PM Joseph Chatelain notifications@github.com wrote:

Looks like you updated the values from the ones I get a few days ago? 12f8541 https://github.com/LCOGT/neoexchange/commit/12f8541b8020e633c4962b27895344ca4cb4535b

I think the changes for the generic 24 windows altered the midpoint calculation. IIRC there was something squirrely as the midpoint wasn't within the cadence start/stop entered into the form in the FT but I couldn't convince myself it was wrong/broken and not just different but that's why I made it a separate commit to the actual fixes for the logout issue so it could be reverted

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/LCOGT/neoexchange/pull/491#issuecomment-702404051, or unsubscribe https://github.com/notifications/unsubscribe-auth/AANRU7BGU3CUVOCILOYQ3JDSITW7BANCNFSM4SA3CFNQ .

-- Dr Tim Lister, Staff Astronomer +1 805 880 1989