LCOGT / neoexchange

NEO observing portal
GNU General Public License v3.0
7 stars 1 forks source link

Issue 493 #494

Closed talister closed 4 years ago

talister commented 4 years ago

Uses the unique key of frameid if we have it to check on creation or existence of a Frame entry. Fixes #493

jchate6 commented 4 years ago

So many broken tests... We should fix that at some point.

Looks good though.

talister commented 4 years ago

So many broken tests... We should fix that at some point.

Looks good though.

3 are new and were being masked by the urljoin problem in find_spec():

======================================================================
ERROR: test_multi_spectra_block (neox.tests.test_plot_spec.SpectraplotTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/tlister/venv/django31_venv/lib64/python3.8/site-packages/mock/mock.py", line 1369, in patched
    return func(*newargs, **newkeywargs)
  File "/home/tlister/git/neoexchange-devel/neoexchange/neox/tests/test_plot_spec.py", line 334, in test_multi_spectra_block
    spec_plot1 = self.browser.find_element_by_xpath("/html/body[@class='page']/div[@id='page-wrapper']/div[@id='page']/div[@id='main']/div[@name='reflec_spec']/div[@class='bk']/div[@class='bk']/div[@class='bk bk-canvas-events']")
  File "/home/tlister/venv/django31_venv/lib64/python3.8/site-packages/selenium/webdriver/remote/webdriver.py", line 394, in find_element_by_xpath
    return self.find_element(by=By.XPATH, value=xpath)
  File "/home/tlister/venv/django31_venv/lib64/python3.8/site-packages/selenium/webdriver/remote/webdriver.py", line 976, in find_element
    return self.execute(Command.FIND_ELEMENT, {
  File "/home/tlister/venv/django31_venv/lib64/python3.8/site-packages/selenium/webdriver/remote/webdriver.py", line 321, in execute
    self.error_handler.check_response(response)
  File "/home/tlister/venv/django31_venv/lib64/python3.8/site-packages/selenium/webdriver/remote/errorhandler.py", line 242, in check_response
    raise exception_class(message, screen, stacktrace)
selenium.common.exceptions.NoSuchElementException: Message: Unable to locate element: /html/body[@class='page']/div[@id='page-wrapper']/div[@id='page']/div[@id='main']/div[@name='reflec_spec']/div[@class='bk']/div[@class='bk']/div[@class='bk bk-canvas-events']

Will look at tomorrow