search

LCOGT / observation-portal-frontend

Frontend for the LCO observation portal
GNU General Public License v3.0
0 stars 3 forks source link

Add a warning message for unsupported filter/readout mode combos #101

Open emannenicholas opened 6 months ago

emannenicholas commented 6 months ago

When a user requests an observation in a readout mode and with a filter for which we do not take sky flats, their data will not be able to be reduced automatically by the pipeline. They will be left with raw data products only. As far as I can tell, this only occurs for the Sinistro cameras. We do not take flatfields in central 2k 2x2 readout mode in any of the U, V, B, R, or I filters. We do warn people about this on the Sinistro webpage. However, I think it would be more helpful to provide a warning in the observation portal (but still let users submit the request).

I think something akin to perhaps a pop-up banner at the top of the Instrument Configuration section that prints a warning would be useful, like so: Screenshot 2024-05-09 at 17 31 22.

To be clear, I am not attached to the aesthetic appearance or placement of the warning message, as we may already have a convention for this, but a warning somewhere, somehow would be appreciated.

jchate6 commented 1 month ago

This seems to have bit us again last night. I'm moving this into the sprint planning project for consideration.

jnation3406 commented 1 month ago

Would it be better to just block users from setting these combinations entirely? Or is there still a reason to allow it if there are no calibrations?

emannenicholas commented 1 month ago

I've spoken with Nikolaus and Daniel, and I think we'd prefer to maintain users ability to request these combinations. I think a warning message in the portal frontend would be the best route. Nikolaus also pointed out that the warning message should direct users to contact Science Support to ask that these special flats be taken if desired.

On Wed, Oct 30, 2024 at 3:21 PM jnation3406 @.***> wrote:

Would it be better to just block users from setting these combinations entirely? Or is there still a reason to allow it if there are no calibrations?

— Reply to this email directly, view it on GitHub https://github.com/LCOGT/observation-portal-frontend/issues/101#issuecomment-2448566531, or unsubscribe https://github.com/notifications/unsubscribe-auth/AW5BZDLOURF5VDOOEN3AKSLZ6FLVDAVCNFSM6AAAAABHQ7YHM2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINBYGU3DMNJTGE . You are receiving this because you authored the thread.Message ID: @.***>

-- Emily Manne-Nicholas, Ph.D. Telescope Operations Scientist Las Cumbres Observatory Pronouns: She/Her/Hers

jnation3406 commented 2 weeks ago

Okay, that's fine. But it does mean (I think?) having a hardcoded list of what is not allowed in the frontend code that we will have to keep up to date...