LCOGT / snex2

Repo for the updated Supernova Exchange, built with the TOM Toolkit and used by the Global Supernova Project collaboration
https://test.supernova.exchange
GNU General Public License v3.0
0 stars 5 forks source link

Use the LCOSettings instead of OCSSettings #27

Closed jnation3406 closed 3 months ago

jnation3406 commented 3 months ago

Looks good, thanks Jon!

is there documentation somewhere for the difference between LCOsettings and OCSsettings?

No not really - the OCSSettings is the base class that others including LCOSettings are based on. For the specific method of the OCSSettings you were calling a facility doesn't matter, but for other methods it could which is why its required now. I assumed the obs you are dealing with are LCO ones so it just makes sense to use that settings then.