search

LCSB-BioCore / COBREXA.jl

Constraint-Based Reconstruction and EXascale Analysis
https://lcsb-biocore.github.io/COBREXA.jl/
Apache License 2.0
43 stars 9 forks source link

freeze SBML dictionary ordering #706

Closed exaexa closed 1 year ago

exaexa commented 1 year ago

Hashtable ordering is more random than was expected; and the unpredictability caused bad/random results when processing large models in a distributed way.

This forcibly freezes the order for SBMLModel so that the ordering issue is avoided completely and forever.

exaexa commented 1 year ago

(I had to intern some code from SBML.jl, but hopefully for good.)

codecov[bot] commented 1 year ago

Codecov Report

Base: 91.13% // Head: 91.30% // Increases project coverage by +0.16% :tada:

Coverage data is based on head (3b56350) compared to base (93d7988). Patch coverage: 97.10% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #706 +/- ## =========================================== + Coverage 91.13% 91.30% +0.16% =========================================== Files 82 82 Lines 2155 2208 +53 =========================================== + Hits 1964 2016 +52 - Misses 191 192 +1 ``` | [Impacted Files](https://codecov.io/gh/LCSB-BioCore/COBREXA.jl/pull/706?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LCSB-BioCore) | Coverage Δ | | |---|---|---| | [src/analysis/flux\_variability\_analysis.jl](https://codecov.io/gh/LCSB-BioCore/COBREXA.jl/pull/706/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LCSB-BioCore#diff-c3JjL2FuYWx5c2lzL2ZsdXhfdmFyaWFiaWxpdHlfYW5hbHlzaXMuamw=) | `93.54% <ø> (ø)` | | | [src/base/types/SBMLModel.jl](https://codecov.io/gh/LCSB-BioCore/COBREXA.jl/pull/706/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LCSB-BioCore#diff-c3JjL2Jhc2UvdHlwZXMvU0JNTE1vZGVsLmps) | `92.75% <97.10%> (+3.34%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LCSB-BioCore). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LCSB-BioCore)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.