LCSB-BioCore / COBREXA.jl

Constraint-Based Reconstruction and EXascale Analysis
https://lcsb-biocore.github.io/COBREXA.jl/
Apache License 2.0
43 stars 9 forks source link

Remove crowding (obsolete via SMOMENT) #725

Closed stelmo closed 1 year ago

stelmo commented 1 year ago

Crowding is obsolete since the inclusion of smoment (just add random or equal weights to all enzymes for the same effect).

Moreover, it should not be a modification.

codecov[bot] commented 1 year ago

Codecov Report

Base: 89.64% // Head: 89.57% // Decreases project coverage by -0.07% :warning:

Coverage data is based on head (9c10454) compared to base (4ff7779). Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## next #725 +/- ## ========================================== - Coverage 89.64% 89.57% -0.08% ========================================== Files 81 80 -1 Lines 1913 1900 -13 ========================================== - Hits 1715 1702 -13 Misses 198 198 ``` Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LCSB-BioCore). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LCSB-BioCore)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

stelmo commented 1 year ago

/format

github-actions[bot] commented 1 year ago

:heavy_check_mark: Auto-formatting triggered by this comment succeeded, commited as 71009e65dcc1ac5c7d306785158fc560e2d8f6b9

stelmo commented 1 year ago

/format

github-actions[bot] commented 1 year ago

:heavy_check_mark: Auto-formatting triggered by this comment succeeded, commited as 9c10454821adf8a8f57d2b41ce1bc96301ba7be4