LCSB-BioCore / COBREXA.jl

Constraint-Based Reconstruction and EXascale Analysis
https://lcsb-biocore.github.io/COBREXA.jl/
Apache License 2.0
42 stars 8 forks source link

Fix test bugs in new parser #732

Closed stelmo closed 1 year ago

stelmo commented 1 year ago

The new parser changes the order of the grrs that get imported. This caused multiple tests to fail. I corrected the order of grrs where appropriate but had to change the test evaluation for gecko and smoment. This is not because the methods don't work anymore, but only because the data we input has a different ordering of the isozymes. This is not a bug, hence the test change.

codecov[bot] commented 1 year ago

Codecov Report

Base: 90.52% // Head: 91.30% // Increases project coverage by +0.77% :tada:

Coverage data is based on head (7224f46) compared to base (eed3038). Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## mk-actual-grr-parser #732 +/- ## ======================================================== + Coverage 90.52% 91.30% +0.77% ======================================================== Files 82 82 Lines 2184 2184 ======================================================== + Hits 1977 1994 +17 + Misses 207 190 -17 ``` | [Impacted Files](https://codecov.io/gh/LCSB-BioCore/COBREXA.jl/pull/732?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LCSB-BioCore) | Coverage Δ | | |---|---|---| | [src/analysis/smoment.jl](https://codecov.io/gh/LCSB-BioCore/COBREXA.jl/pull/732?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LCSB-BioCore#diff-c3JjL2FuYWx5c2lzL3Ntb21lbnQuamw=) | `100.00% <0.00%> (+5.55%)` | :arrow_up: | | [src/base/utils/gecko.jl](https://codecov.io/gh/LCSB-BioCore/COBREXA.jl/pull/732?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LCSB-BioCore#diff-c3JjL2Jhc2UvdXRpbHMvZ2Vja28uamw=) | `100.00% <0.00%> (+9.09%)` | :arrow_up: | | [src/base/types/wrappers/GeckoModel.jl](https://codecov.io/gh/LCSB-BioCore/COBREXA.jl/pull/732?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LCSB-BioCore#diff-c3JjL2Jhc2UvdHlwZXMvd3JhcHBlcnMvR2Vja29Nb2RlbC5qbA==) | `91.66% <0.00%> (+13.88%)` | :arrow_up: | | [src/base/utils/smoment.jl](https://codecov.io/gh/LCSB-BioCore/COBREXA.jl/pull/732?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LCSB-BioCore#diff-c3JjL2Jhc2UvdXRpbHMvc21vbWVudC5qbA==) | `80.00% <0.00%> (+20.00%)` | :arrow_up: | | [src/base/types/wrappers/SMomentModel.jl](https://codecov.io/gh/LCSB-BioCore/COBREXA.jl/pull/732?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LCSB-BioCore#diff-c3JjL2Jhc2UvdHlwZXMvd3JhcHBlcnMvU01vbWVudE1vZGVsLmps) | `71.42% <0.00%> (+64.28%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LCSB-BioCore). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LCSB-BioCore)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

exaexa commented 1 year ago

/format

github-actions[bot] commented 1 year ago

:heavy_check_mark: Auto-formatting triggered by this comment succeeded, commited as 7224f462c368f13b03eb66f9ea8a6d9cec9b73f4