LCSB-BioCore / COBREXA.jl

Constraint-Based Reconstruction and EXascale Analysis
https://lcsb-biocore.github.io/COBREXA.jl/
Apache License 2.0
42 stars 8 forks source link

Generalize loopless modification #745

Closed stelmo closed 8 months ago

stelmo commented 1 year ago

Change loopless so that it can be applied to any model, e.g. enzyme constrained models

stelmo commented 1 year ago

I could add an argument to this modification requesting the row indices that correspond to metabolites in the order of metabolites

codecov[bot] commented 1 year ago

Codecov Report

Base: 88.28% // Head: 88.30% // Increases project coverage by +0.01% :tada:

Coverage data is based on head (2a889ac) compared to base (65f79be). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## next #745 +/- ## ========================================== + Coverage 88.28% 88.30% +0.01% ========================================== Files 85 85 Lines 2075 2078 +3 ========================================== + Hits 1832 1835 +3 Misses 243 243 ``` | [Impacted Files](https://codecov.io/gh/LCSB-BioCore/COBREXA.jl/pull/745?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LCSB-BioCore) | Coverage Δ | | |---|---|---| | [src/analysis/modifications/loopless.jl](https://codecov.io/gh/LCSB-BioCore/COBREXA.jl/pull/745?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LCSB-BioCore#diff-c3JjL2FuYWx5c2lzL21vZGlmaWNhdGlvbnMvbG9vcGxlc3Muamw=) | `100.00% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LCSB-BioCore). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LCSB-BioCore)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

stelmo commented 1 year ago

/format

github-actions[bot] commented 1 year ago

:heavy_check_mark: Auto-formatting triggered by this comment succeeded, commited as 2a889ac1a2c1212535c4dc8833ef5a923d0e5441

stelmo commented 8 months ago

continued in #810