Closed stelmo closed 1 year ago
not sure why the tests did not run
no idea why this is giving an error
[ Info: Precompiling COBREXA [babc4406-5200-4a30-9033-bf5ae714c842]
WARNING: Method definition make_enzyme_constrained_model(COBREXA.Types.AbstractMetabolicModel) in module Reconstruction at C:\Users\stelmo\Documents\GitHub\pkgs\COBREXA.jl\src\reconstruction\enzyme_constrained.jl:39 overwritten at C:\Users\stelmo\Documents\GitHub\pkgs\COBREXA.jl\src\reconstruction\enzyme_constrained.jl:179.
** incremental compilation may be fatally broken for this module **
WARNING: Method definition kwcall(Any, typeof(COBREXA.Reconstruction.make_enzyme_constrained_model), COBREXA.Types.AbstractMetabolicModel) in module Reconstruction at C:\Users\stelmo\Documents\GitHub\pkgs\COBREXA.jl\src\reconstruction\enzyme_constrained.jl:39 overwritten at C:\Users\stelmo\Documents\GitHub\pkgs\COBREXA.jl\src\reconstruction\enzyme_constrained.jl:179.
** incremental compilation may be fatally broken for this module **
┌ Warning: Replacing docs for `COBREXA.Reconstruction.make_enzyme_constrained_model :: Tuple{COBREXA.Types.AbstractMetabolicModel}` in module `COBREXA.Reconstruction`
└ @ Base.Docs docs\Docs.jl:243
Ahhh, you can't dispatch on kwargs!
Sigh, this means that this PR won't work 😢
Fixed this!
also changed the with
pipe to make it more general for simplified enzyme models
Base: 88.19% // Head: 88.22% // Increases project coverage by +0.02%
:tada:
Coverage data is based on head (
68f46f3
) compared to base (2e1fc07
). Patch coverage: 100.00% of modified lines in pull request are covered.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
/format
:heavy_check_mark: Auto-formatting triggered by this comment succeeded, commited as a3c4fc7dde6180a94b29286a00c0d7a523de0147
total_enzyme_capacity
is used in the simplified enzyme constrained model