LCSB-BioCore / COBREXA.jl

Constraint-Based Reconstruction and EXascale Analysis
https://lcsb-biocore.github.io/COBREXA.jl/
Apache License 2.0
42 stars 8 forks source link

Make kwargs for convenience enzyme constrained consistent #759

Closed stelmo closed 1 year ago

stelmo commented 1 year ago

total_enzyme_capacity is used in the simplified enzyme constrained model

stelmo commented 1 year ago

not sure why the tests did not run

stelmo commented 1 year ago

no idea why this is giving an error

[ Info: Precompiling COBREXA [babc4406-5200-4a30-9033-bf5ae714c842]
WARNING: Method definition make_enzyme_constrained_model(COBREXA.Types.AbstractMetabolicModel) in module Reconstruction at C:\Users\stelmo\Documents\GitHub\pkgs\COBREXA.jl\src\reconstruction\enzyme_constrained.jl:39 overwritten at C:\Users\stelmo\Documents\GitHub\pkgs\COBREXA.jl\src\reconstruction\enzyme_constrained.jl:179.
  ** incremental compilation may be fatally broken for this module **

WARNING: Method definition kwcall(Any, typeof(COBREXA.Reconstruction.make_enzyme_constrained_model), COBREXA.Types.AbstractMetabolicModel) in module Reconstruction at C:\Users\stelmo\Documents\GitHub\pkgs\COBREXA.jl\src\reconstruction\enzyme_constrained.jl:39 overwritten at C:\Users\stelmo\Documents\GitHub\pkgs\COBREXA.jl\src\reconstruction\enzyme_constrained.jl:179.
  ** incremental compilation may be fatally broken for this module **
┌ Warning: Replacing docs for `COBREXA.Reconstruction.make_enzyme_constrained_model :: Tuple{COBREXA.Types.AbstractMetabolicModel}` in module `COBREXA.Reconstruction`
└ @ Base.Docs docs\Docs.jl:243
stelmo commented 1 year ago

Ahhh, you can't dispatch on kwargs!

stelmo commented 1 year ago

Sigh, this means that this PR won't work 😢

stelmo commented 1 year ago

Fixed this!

stelmo commented 1 year ago

also changed the with pipe to make it more general for simplified enzyme models

codecov[bot] commented 1 year ago

Codecov Report

Base: 88.19% // Head: 88.22% // Increases project coverage by +0.02% :tada:

Coverage data is based on head (68f46f3) compared to base (2e1fc07). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## next #759 +/- ## ========================================== + Coverage 88.19% 88.22% +0.02% ========================================== Files 88 88 Lines 2110 2114 +4 ========================================== + Hits 1861 1865 +4 Misses 249 249 ``` | [Impacted Files](https://codecov.io/gh/LCSB-BioCore/COBREXA.jl/pull/759?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LCSB-BioCore) | Coverage Δ | | |---|---|---| | [src/types/wrappers/EnzymeConstrainedModel.jl](https://codecov.io/gh/LCSB-BioCore/COBREXA.jl/pull/759?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LCSB-BioCore#diff-c3JjL3R5cGVzL3dyYXBwZXJzL0VuenltZUNvbnN0cmFpbmVkTW9kZWwuamw=) | `92.68% <ø> (ø)` | | | [src/reconstruction/enzyme\_constrained.jl](https://codecov.io/gh/LCSB-BioCore/COBREXA.jl/pull/759?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LCSB-BioCore#diff-c3JjL3JlY29uc3RydWN0aW9uL2VuenltZV9jb25zdHJhaW5lZC5qbA==) | `100.00% <100.00%> (ø)` | | | [src/reconstruction/pipes/enzymes.jl](https://codecov.io/gh/LCSB-BioCore/COBREXA.jl/pull/759?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LCSB-BioCore#diff-c3JjL3JlY29uc3RydWN0aW9uL3BpcGVzL2VuenltZXMuamw=) | `100.00% <100.00%> (ø)` | | | [...rc/reconstruction/simplified\_enzyme\_constrained.jl](https://codecov.io/gh/LCSB-BioCore/COBREXA.jl/pull/759?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LCSB-BioCore#diff-c3JjL3JlY29uc3RydWN0aW9uL3NpbXBsaWZpZWRfZW56eW1lX2NvbnN0cmFpbmVkLmps) | `100.00% <100.00%> (ø)` | | | [...types/wrappers/SimplifiedEnzymeConstrainedModel.jl](https://codecov.io/gh/LCSB-BioCore/COBREXA.jl/pull/759?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LCSB-BioCore#diff-c3JjL3R5cGVzL3dyYXBwZXJzL1NpbXBsaWZpZWRFbnp5bWVDb25zdHJhaW5lZE1vZGVsLmps) | `66.66% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LCSB-BioCore). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LCSB-BioCore)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

stelmo commented 1 year ago

/format

github-actions[bot] commented 1 year ago

:heavy_check_mark: Auto-formatting triggered by this comment succeeded, commited as a3c4fc7dde6180a94b29286a00c0d7a523de0147