LCSB-BioCore / COBREXA.jl

Constraint-Based Reconstruction and EXascale Analysis
https://lcsb-biocore.github.io/COBREXA.jl/
Apache License 2.0
42 stars 8 forks source link

Extend simplified enzyme model to include multiple capacity constraints #772

Closed stelmo closed 1 year ago

stelmo commented 1 year ago

/format

github-actions[bot] commented 1 year ago

:heavy_check_mark: Auto-formatting triggered by this comment succeeded, commited as 3899607fcaa9d1d7d8b00ebb7515e95edee4c31e

stelmo commented 1 year ago

No idea why next is not failing on this test :/ the solver seems to give different values for the exact same problem... Changed the solver expected solution to report fewer decimal places

stelmo commented 1 year ago

Will rebase on #773

stelmo commented 1 year ago

/format

github-actions[bot] commented 1 year ago

:heavy_check_mark: Auto-formatting triggered by this comment succeeded, commited as ed0da18668d4b7a1b388f999dad9afd690723094

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 82.92% and project coverage change: +2.74 :tada:

Comparison is base (10b0a29) 86.55% compared to head (be78535) 89.30%.

:exclamation: Current head be78535 differs from pull request most recent head 628461f. Consider uploading reports for the commit 628461f to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## next #772 +/- ## ========================================== + Coverage 86.55% 89.30% +2.74% ========================================== Files 93 92 -1 Lines 2388 2422 +34 ========================================== + Hits 2067 2163 +96 + Misses 321 259 -62 ``` | [Impacted Files](https://codecov.io/gh/LCSB-BioCore/COBREXA.jl/pull/772?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LCSB-BioCore) | Coverage Δ | | |---|---|---| | [src/wrappers/bits/enzyme\_constrained.jl](https://codecov.io/gh/LCSB-BioCore/COBREXA.jl/pull/772?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LCSB-BioCore#diff-c3JjL3dyYXBwZXJzL2JpdHMvZW56eW1lX2NvbnN0cmFpbmVkLmps) | `100.00% <ø> (ø)` | | | [src/types/wrappers/EqualGrowthCommunityModel.jl](https://codecov.io/gh/LCSB-BioCore/COBREXA.jl/pull/772?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LCSB-BioCore#diff-c3JjL3R5cGVzL3dyYXBwZXJzL0VxdWFsR3Jvd3RoQ29tbXVuaXR5TW9kZWwuamw=) | `81.57% <33.33%> (+81.57%)` | :arrow_up: | | [src/types/models/CommunityModel.jl](https://codecov.io/gh/LCSB-BioCore/COBREXA.jl/pull/772?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LCSB-BioCore#diff-c3JjL3R5cGVzL21vZGVscy9Db21tdW5pdHlNb2RlbC5qbA==) | `95.23% <50.00%> (+40.10%)` | :arrow_up: | | [...rc/reconstruction/simplified\_enzyme\_constrained.jl](https://codecov.io/gh/LCSB-BioCore/COBREXA.jl/pull/772?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LCSB-BioCore#diff-c3JjL3JlY29uc3RydWN0aW9uL3NpbXBsaWZpZWRfZW56eW1lX2NvbnN0cmFpbmVkLmps) | `100.00% <100.00%> (ø)` | | | [src/wrappers/SimplifiedEnzymeConstrainedModel.jl](https://codecov.io/gh/LCSB-BioCore/COBREXA.jl/pull/772?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LCSB-BioCore#diff-c3JjL3dyYXBwZXJzL1NpbXBsaWZpZWRFbnp5bWVDb25zdHJhaW5lZE1vZGVsLmps) | `88.88% <100.00%> (+10.31%)` | :arrow_up: | | [src/wrappers/misc/enzyme\_constrained.jl](https://codecov.io/gh/LCSB-BioCore/COBREXA.jl/pull/772?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LCSB-BioCore#diff-c3JjL3dyYXBwZXJzL21pc2MvZW56eW1lX2NvbnN0cmFpbmVkLmps) | `100.00% <100.00%> (ø)` | | | [src/wrappers/EnzymeConstrainedModel.jl](https://codecov.io/gh/LCSB-BioCore/COBREXA.jl/pull/772?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LCSB-BioCore#diff-c3JjL3dyYXBwZXJzL0VuenltZUNvbnN0cmFpbmVkTW9kZWwuamw=) | `95.34% <0.00%> (+2.32%)` | :arrow_up: | | [src/types/misc/CommunityModel.jl](https://codecov.io/gh/LCSB-BioCore/COBREXA.jl/pull/772?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LCSB-BioCore#diff-c3JjL3R5cGVzL21pc2MvQ29tbXVuaXR5TW9kZWwuamw=) | `95.65% <0.00%> (+26.08%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LCSB-BioCore). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LCSB-BioCore)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

stelmo commented 1 year ago

/format

github-actions[bot] commented 1 year ago

:heavy_check_mark: Auto-formatting triggered by this comment succeeded, commited as a458d78bb7a3f3a70fd83cde3408b0f9864accf9

stelmo commented 1 year ago

/format

github-actions[bot] commented 1 year ago

:heavy_check_mark: Auto-formatting triggered by this comment succeeded, commited as d39fc03c0f3865497691a4c0078e81d9607acadb

stelmo commented 1 year ago

/format

github-actions[bot] commented 1 year ago

:sunny: Auto-formatting triggered by this comment succeeded, but the code was already formatted correctly.

stelmo commented 1 year ago

/format

github-actions[bot] commented 1 year ago

:heavy_check_mark: Auto-formatting triggered by this comment succeeded, commited as be78535deaab8159252195fc079fa1992f8860a5

stelmo commented 1 year ago

Finally fixed this! Should also fix the broken things in next